Change in ...osmo-msc[master]: vlr_lu_fsm: fix missing event for IMEISV

neels gerrit-no-reply at lists.osmocom.org
Thu Aug 8 12:21:26 UTC 2019


neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-msc/+/15111 )

Change subject: vlr_lu_fsm: fix missing event for IMEISV
......................................................................

vlr_lu_fsm: fix missing event for IMEISV

Event VLR_ULA_E_ID_IMEISV is listed as permitted in VLR_ULA_S_WAIT_LU_COMPL,
but is missing from the switch() on the incoming event. So, sending an IMEISV
identity during the WAIT_LU_COMPL state would crash osmo-msc.

When receiving an IMEISV, vlr_subscr_set_imeisv() in turn calls
vlr_subscr_set_imei(), so as far as the lu_fsm is concerned, receiving an
IMEISV is identical to receiving an IMEI, and it can continue to send a Check
IMEI request to the HLR. Thus simply add VLR_ULA_E_ID_IMEISV to the
VLR_ULA_E_ID_IMEI switch case.

Change-Id: I11106cb108a4b1406ff9a8b8ff5761440a274dad
---
M src/libvlr/vlr_lu_fsm.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved
  laforge: Looks good to me, approved



diff --git a/src/libvlr/vlr_lu_fsm.c b/src/libvlr/vlr_lu_fsm.c
index 87bf7a5..454709f 100644
--- a/src/libvlr/vlr_lu_fsm.c
+++ b/src/libvlr/vlr_lu_fsm.c
@@ -1253,6 +1253,7 @@
 				       LU_COMPL_VLR_E_NEW_TMSI_ACK, NULL);
 		break;
 	case VLR_ULA_E_ID_IMEI:
+	case VLR_ULA_E_ID_IMEISV:
 		/* Got the IMEI from ME, now send it to HLR */
 		vlr_subscr_tx_req_check_imei(lfp->vsub);
 		break;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15111
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I11106cb108a4b1406ff9a8b8ff5761440a274dad
Gerrit-Change-Number: 15111
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190808/b34cce24/attachment.html>


More information about the gerrit-log mailing list