Change in ...osmo-sip-connector[master]: Logging: Make use of Levels

keith gerrit-no-reply at lists.osmocom.org
Wed Aug 7 10:43:53 UTC 2019


keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15078 )

Change subject: Logging: Make use of Levels
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/15078/2/src/mncc.c 
File src/mncc.c:

https://gerrit.osmocom.org/#/c/15078/2/src/mncc.c@518 
PS2, Line 518: 	LOGP(DMNCC, LOGL_NOTICE,
> ACK. […]
I was thinking.. If you really want to watch/log extra details of what's going on, you set INFO, if you want to just get regular logging of calls, you get NOTICE. 

But you guys feel that NOTICE is not for that?

so if i demote those notice to info, there's no way to just log call occurence without logging juicy details, unless i demote the juicy details to DEBUG and the the things currently on DEBUG need to go to... VERBOSE_DEBUG ??



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15078
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: Ie0014043d93303a87cbb8bb351e439ff78651cbe
Gerrit-Change-Number: 15078
Gerrit-PatchSet: 2
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 07 Aug 2019 10:43:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190807/b6a4fbb5/attachment.html>


More information about the gerrit-log mailing list