Change in ...osmo-sip-connector[master]: Add further logging.

pespin gerrit-no-reply at lists.osmocom.org
Tue Aug 6 12:00:14 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14997 )

Change subject: Add further logging.
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.osmocom.org/#/c/14997/1/src/mncc.c 
File src/mncc.c:

https://gerrit.osmocom.org/#/c/14997/1/src/mncc.c@191 
PS1, Line 191: 	struct in_addr net = { .s_addr = other->ip };
> just making notes... […]
So the result is probably fine because htonl() and ntohl() are implemented the same way afaik, but from what you say, it should be ntohl() then since apparently other->ip is network byte order, and what we send over the unix MNCC socket appears to be host byte order.

You can make sure also by checking implementation of the peer on the other side of the unix mncc socket.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14997
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: I2620cce245be199d849d8fad3fc998c96c243f6b
Gerrit-Change-Number: 14997
Gerrit-PatchSet: 7
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 06 Aug 2019 12:00:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: keith <keith at rhizomatica.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190806/51f6279c/attachment.html>


More information about the gerrit-log mailing list