Change in ...osmo-sip-connector[master]: Add further logging.

pespin gerrit-no-reply at lists.osmocom.org
Tue Aug 6 08:10:18 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14997 )

Change subject: Add further logging.
......................................................................


Patch Set 7:

(2 comments)

https://gerrit.osmocom.org/#/c/14997/1/src/mncc.c 
File src/mncc.c:

https://gerrit.osmocom.org/#/c/14997/1/src/mncc.c@191 
PS1, Line 191: 	struct in_addr net = { .s_addr = other->ip };
> Yes, mncc.ip is in host byte order, if that's the correct terminology. certainly, using mncc. […]
Well, according to existing code [mncc.ip = htonl(other->ip)], other->ip is host byte order, and mncc.ip is network byte order. And afar the struct in_addr net expects to have content in net byte order.

So if I'm not wrong, either use "struct in_addr net = { .s_addr = mncc.ip };" or function above should be ntohl() instead of htonl().


https://gerrit.osmocom.org/#/c/14997/1/src/mncc.c@192 
PS1, Line 192: 	LOGP(DMNCC, LOGL_DEBUG, "SEND rtp_connect: IP=(%s) PORT=(%u)\n", inet_ntoa(net), mncc.port);
> There are other places in the code that use inet_ntoa() […]
Having inet_ntoa already in some places in code doesn't mean we should keep adding references to it. Using inet_ntop() doesn't imply a big change, it's mostly declaring a local buffer in the stack + using the new function, so let's use proper functions before merging since it's not a lot of extra hassle.

man inet_ntop: "inet_ntop() extends the inet_ntoa(3) function to support multiple address families, inet_ntoa(3) is now considered to  be  deprecated  in  favor  of inet_ntop()."



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14997
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: I2620cce245be199d849d8fad3fc998c96c243f6b
Gerrit-Change-Number: 14997
Gerrit-PatchSet: 7
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 06 Aug 2019 08:10:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: keith <keith at rhizomatica.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190806/331511ae/attachment.html>


More information about the gerrit-log mailing list