Change in ...osmo-gsm-manuals[master]: warnings check not default

laforge gerrit-no-reply at
Mon Aug 5 17:50:36 UTC 2019

laforge has submitted this change and it was merged. ( )

Change subject: warnings check not default
...................................................................... warnings check not default

Only check for asciidoc warnings in "make check" if
ASCIIDOC_WARNINGS_CHECK is set. Enable it in by using the
new ./configure --enable-asciidoc-warnings-check parameter (similar to
--enable-werror in other Osmocom projects' files).

Related: OS#4140
Change-Id: Iac993a0d1b17205397a1f1ef1a7bd3f9df739e36
M build/
M contrib/
3 files changed, 14 insertions(+), 2 deletions(-)

  laforge: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  Jenkins Builder: Verified

diff --git a/build/ b/build/
index 77f3b1d..7cb660f 100644
--- a/build/
+++ b/build/
@@ -75,7 +75,10 @@
 		a2x -vv $(A2X_OPTS) $(notdir $<)
+	if [ -n "$$ASCIIDOC_WARNINGS_CHECK" ]; then \
+	fi
 $(ASCIIDOC_CHECKS): %.check: %.adoc %-docinfo.xml \
diff --git a/ b/
index 9858af6..1017e9c 100644
--- a/
+++ b/
@@ -28,6 +28,15 @@
 	AC_MSG_ERROR("missing dependencies!")
+# Asciidoc warnings check (OS#4140)
+		[--enable-asciidoc-warnings-check],
+		[Fail the build if asciidoc prints any warnings]
+	)],
+	[asciidoc_warnings_check=$enableval], [asciidoc_warnings_check="no"])
+AM_CONDITIONAL([ASCIIDOC_WARNINGS_CHECK], [test x"$asciidoc_warnings_check" = x"yes"])
diff --git a/contrib/ b/contrib/
index 0c40e2f..cf709b2 100755
--- a/contrib/
+++ b/contrib/
@@ -12,7 +12,7 @@
 autoreconf -fi
+./configure --enable-asciidoc-warnings-check

To view, visit
To unsubscribe, or for help writing mail filters, visit

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: Iac993a0d1b17205397a1f1ef1a7bd3f9df739e36
Gerrit-Change-Number: 15031
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at>
Gerrit-Reviewer: pespin <pespin at>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the gerrit-log mailing list