Change in ...osmo-pcap[master]: Remove undefined param passed to {logging, osmo_stats}_vty_add_cmds

laforge gerrit-no-reply at lists.osmocom.org
Mon Aug 5 17:49:38 UTC 2019


laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-pcap/+/15052 )

Change subject: Remove undefined param passed to {logging,osmo_stats}_vty_add_cmds
......................................................................

Remove undefined param passed to {logging,osmo_stats}_vty_add_cmds

Since March 15th 2017, libosmocore API logging_vty_add_cmds() had its
parameter removed (c65c5b4ea075ef6cef11fff9442ae0b15c1d6af7). However,
definition in C file doesn't contain "(void)", which means number of
parameters is undefined and thus compiler doesn't complain. Let's remove
parameters from all callers before enforcing "(void)" on it.
API osmo_stats_vty_add_cmds never had a param list but has seem problem
(no "void"), so some users decided to pass a parameter to it.

Change-Id: I2e1ab7005514f1a06cac03e967aa5c8ea472e671
Related: OS#4138
---
M src/osmo_client_main.c
M src/osmo_server_main.c
2 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/osmo_client_main.c b/src/osmo_client_main.c
index a28c4b7..5a8da96 100644
--- a/src/osmo_client_main.c
+++ b/src/osmo_client_main.c
@@ -186,8 +186,8 @@
 
 	vty_info.copyright = osmopcap_copyright;
 	vty_init(&vty_info);
-	logging_vty_add_cmds(&log_info);
-	osmo_stats_vty_add_cmds(&log_info);
+	logging_vty_add_cmds();
+	osmo_stats_vty_add_cmds();
 
 	/* parse options */
 	handle_options(argc, argv);
diff --git a/src/osmo_server_main.c b/src/osmo_server_main.c
index 3e399af..22d0f22 100644
--- a/src/osmo_server_main.c
+++ b/src/osmo_server_main.c
@@ -199,8 +199,8 @@
 
 	vty_info.copyright = osmopcap_copyright;
 	vty_init(&vty_info);
-	logging_vty_add_cmds(&log_info);
-	osmo_stats_vty_add_cmds(&log_info);
+	logging_vty_add_cmds();
+	osmo_stats_vty_add_cmds();
 
 	/* parse options */
 	handle_options(argc, argv);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/15052
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-Change-Id: I2e1ab7005514f1a06cac03e967aa5c8ea472e671
Gerrit-Change-Number: 15052
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190805/518d33f3/attachment.html>


More information about the gerrit-log mailing list