Change in ...osmocom-bb[master]: Remove undefined param passed to logging_vty_add_cmds

laforge gerrit-no-reply at lists.osmocom.org
Mon Aug 5 17:49:29 UTC 2019


laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/15050 )

Change subject: Remove undefined param passed to logging_vty_add_cmds
......................................................................

Remove undefined param passed to logging_vty_add_cmds

Since March 15th 2017, libosmocore API logging_vty_add_cmds() had its
parameter removed (c65c5b4ea075ef6cef11fff9442ae0b15c1d6af7). However,
definition in C file doesn't contain "(void)", which means number of
parameters is undefined and thus compiler doesn't complain. Let's remove
parameters from all callers before enforcing "(void)" on it.

Change-Id: I25baaa30b097dad2fae507c5321778f43e863611
Related: OS#4138
---
M src/host/layer23/src/mobile/app_mobile.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/host/layer23/src/mobile/app_mobile.c b/src/host/layer23/src/mobile/app_mobile.c
index d7c65f0..f0f118b 100644
--- a/src/host/layer23/src/mobile/app_mobile.c
+++ b/src/host/layer23/src/mobile/app_mobile.c
@@ -440,7 +440,7 @@
 
 	vty_info.tall_ctx = l23_ctx;
 	vty_init(&vty_info);
-	logging_vty_add_cmds(NULL);
+	logging_vty_add_cmds();
 	ms_vty_init();
 	dummy_conn.priv = NULL;
 	vty_reading = 1;

-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/15050
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I25baaa30b097dad2fae507c5321778f43e863611
Gerrit-Change-Number: 15050
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190805/0ba1a877/attachment.html>


More information about the gerrit-log mailing list