This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15044 ) Change subject: Remove undefined param passed to {logging,osmo_stats}_vty_add_cmds ...................................................................... Remove undefined param passed to {logging,osmo_stats}_vty_add_cmds Since March 15th 2017, libosmocore API logging_vty_add_cmds() had its parameter removed (c65c5b4ea075ef6cef11fff9442ae0b15c1d6af7). However, definition in C file doesn't contain "(void)", which means number of parameters is undefined and thus compiler doesn't complain. Let's remove parameters from all callers before enforcing "(void)" on it. API osmo_stats_vty_add_cmds never had a param list but has seem problem (no "void"), so some users decided to pass a parameter to it. Change-Id: Ic4af704958819e6f65ac01be33ef5b3d69628ad0 Related: OS#4138 --- M src/gprs/gb_proxy_main.c M src/gprs/gtphub_main.c M src/gprs/sgsn_main.c 3 files changed, 5 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/gprs/gb_proxy_main.c b/src/gprs/gb_proxy_main.c index 1e1aeac..4319fda 100644 --- a/src/gprs/gb_proxy_main.c +++ b/src/gprs/gb_proxy_main.c @@ -284,9 +284,9 @@ vty_info.copyright = openbsc_copyright; vty_init(&vty_info); - logging_vty_add_cmds(NULL); + logging_vty_add_cmds(); osmo_talloc_vty_add_cmds(); - osmo_stats_vty_add_cmds(&gprs_log_info); + osmo_stats_vty_add_cmds(); gbproxy_vty_init(); handle_options(argc, argv); diff --git a/src/gprs/gtphub_main.c b/src/gprs/gtphub_main.c index 6d470bd..f693f09 100644 --- a/src/gprs/gtphub_main.c +++ b/src/gprs/gtphub_main.c @@ -356,7 +356,7 @@ vty_info.copyright = gtphub_copyright; vty_init(&vty_info); - logging_vty_add_cmds(NULL); + logging_vty_add_cmds(); osmo_talloc_vty_add_cmds(); gtphub_vty_init(hub, cfg); diff --git a/src/gprs/sgsn_main.c b/src/gprs/sgsn_main.c index 3543517..ecfb79b 100644 --- a/src/gprs/sgsn_main.c +++ b/src/gprs/sgsn_main.c @@ -384,9 +384,9 @@ vty_info.copyright = openbsc_copyright; vty_init(&vty_info); - logging_vty_add_cmds(NULL); + logging_vty_add_cmds(); osmo_talloc_vty_add_cmds(); - osmo_stats_vty_add_cmds(&gprs_log_info); + osmo_stats_vty_add_cmds(); sgsn_vty_init(&sgsn->cfg); ctrl_vty_init(tall_sgsn_ctx); -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15044 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ic4af704958819e6f65ac01be33ef5b3d69628ad0 Gerrit-Change-Number: 15044 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at gnumonks.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190805/e4abdf06/attachment.htm>