Change in ...libosmo-sccp[master]: Remove undefined param passed to {logging, osmo_stats}_vty_add_cmds

laforge gerrit-no-reply at lists.osmocom.org
Mon Aug 5 17:45:53 UTC 2019


laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/15040 )

Change subject: Remove undefined param passed to {logging,osmo_stats}_vty_add_cmds
......................................................................

Remove undefined param passed to {logging,osmo_stats}_vty_add_cmds

Since March 15th 2017, libosmocore API logging_vty_add_cmds() had its
parameter removed (c65c5b4ea075ef6cef11fff9442ae0b15c1d6af7). However,
definition in C file doesn't contain "(void)", which means number of
parameters is undefined and thus compiler doesn't complain. Let's remove
parameters from all callers before enforcing "(void)" on it.

Related: OS#4138
Change-Id: Iedd11f816002b686f0ddb54c0cf7ba4e229e21e3
---
M stp/stp_main.c
M tests/vty/ss7_asp_vty_test.c
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/stp/stp_main.c b/stp/stp_main.c
index ff33959..a3e3a85 100644
--- a/stp/stp_main.c
+++ b/stp/stp_main.c
@@ -177,7 +177,7 @@
 
 	osmo_ss7_init();
 	osmo_fsm_log_addr(false);
-	logging_vty_add_cmds(&log_info);
+	logging_vty_add_cmds();
 	osmo_stats_vty_add_cmds();
 	osmo_ss7_vty_init_sg(tall_stp_ctx);
 	osmo_sccp_vty_init();
diff --git a/tests/vty/ss7_asp_vty_test.c b/tests/vty/ss7_asp_vty_test.c
index 6918df4..76ffcf2 100644
--- a/tests/vty/ss7_asp_vty_test.c
+++ b/tests/vty/ss7_asp_vty_test.c
@@ -162,7 +162,7 @@
 	vty_init(&vty_info);
 
 	osmo_init_logging2(root_ctx, &log_info);
-	logging_vty_add_cmds(&log_info);
+	logging_vty_add_cmds();
 
 	osmo_ss7_init();
 	osmo_ss7_vty_init_asp(root_ctx);

-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/15040
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Iedd11f816002b686f0ddb54c0cf7ba4e229e21e3
Gerrit-Change-Number: 15040
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190805/d5f54295/attachment.html>


More information about the gerrit-log mailing list