Change in ...libosmocore[master]: tests: logging: Remove undefined param passed to logging_vty_add_cmds

laforge gerrit-no-reply at lists.osmocom.org
Mon Aug 5 17:45:08 UTC 2019


laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/15038 )

Change subject: tests: logging: Remove undefined param passed to logging_vty_add_cmds
......................................................................

tests: logging: Remove undefined param passed to logging_vty_add_cmds

Since March 15th 2017, libosmocore API logging_vty_add_cmds() had its
parameter removed (c65c5b4ea075ef6cef11fff9442ae0b15c1d6af7). However,
definition in C file doesn't contain "(void)", which means number of
parameters is undefined and thus compiler doesn't complain. Let's remove
parameters from all callers before enforcing "(void)" on it.

Related: OS#4138
Change-Id: Iaea795521361a8e5b3b45eaeb35e6eda69163af3
---
M tests/logging/logging_vty_test.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/tests/logging/logging_vty_test.c b/tests/logging/logging_vty_test.c
index 806a460..30426f3 100644
--- a/tests/logging/logging_vty_test.c
+++ b/tests/logging/logging_vty_test.c
@@ -246,7 +246,7 @@
 
 	handle_options(argc, argv);
 
-	logging_vty_add_cmds(&log_info);
+	logging_vty_add_cmds();
 	osmo_talloc_vty_add_cmds();
 
 	log_set_print_category(osmo_stderr_target, 1);

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15038
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Iaea795521361a8e5b3b45eaeb35e6eda69163af3
Gerrit-Change-Number: 15038
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190805/e867b5d1/attachment.html>


More information about the gerrit-log mailing list