Change in ...osmo-sip-connector[master]: Only send update to MNCC if media info changed.

keith gerrit-no-reply at lists.osmocom.org
Mon Aug 5 17:16:25 UTC 2019


keith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15010 )

Change subject: Only send update to MNCC if media info changed.
......................................................................

Only send update to MNCC if media info changed.

Do not send an MNCC_RTP_CONNECT as a result of a SIP re-INVITE,
unless the media connection information has changed.

Change-Id: I7c48300092a309e50a8fe091b30e395e7c72de9d
---
M src/sip.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved



diff --git a/src/sip.c b/src/sip.c
index 4e011bd..0179226 100644
--- a/src/sip.c
+++ b/src/sip.c
@@ -224,9 +224,9 @@
 		LOGP(DSIP, LOGL_NOTICE, "Media IP:port in re-INVITE: (%s:%u)\n", inet_ntoa(net), leg->base.port);
 		if (ip != leg->base.ip || port != leg->base.port) {
 			LOGP(DSIP, LOGL_NOTICE, "re-INVITE changes media connection.\n");
+			if (other->update_rtp)
+				other->update_rtp(leg->base.call->remote);
 		}
-		if (other->update_rtp)
-			other->update_rtp(leg->base.call->remote);
 		sdp = sdp_create_file(leg, other, sdp_sendrecv);
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15010
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: I7c48300092a309e50a8fe091b30e395e7c72de9d
Gerrit-Change-Number: 15010
Gerrit-PatchSet: 2
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190805/53af8585/attachment.html>


More information about the gerrit-log mailing list