Change in ...osmo-sip-connector[master]: Add support for MNCC HOLD/RETRIEVE

keith gerrit-no-reply at lists.osmocom.org
Mon Aug 5 17:14:07 UTC 2019


keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14996 )

Change subject: Add support for MNCC HOLD/RETRIEVE
......................................................................


Patch Set 9: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/14996/8/src/mncc.c 
File src/mncc.c:

https://gerrit.osmocom.org/#/c/14996/8/src/mncc.c@719 
PS8, Line 719: 	/* In case of call waiting/swap, At this point we need to tell the MSC to send 
> Sorry to say so, but you need to remove this whitespace at the end of the line (otherwise I'll hate  […]
yeah.. I already saw it..



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14996
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: Ife7bdab20cde92b7ce550215bab28b36a0f302e9
Gerrit-Change-Number: 14996
Gerrit-PatchSet: 9
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Aug 2019 17:14:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190805/af401552/attachment.html>


More information about the gerrit-log mailing list