Change in ...osmo-sip-connector[master]: Remove undefined param passed to {logging, osmo_stats}_vty_add_cmds

pespin gerrit-no-reply at lists.osmocom.org
Mon Aug 5 14:17:01 UTC 2019


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15049


Change subject: Remove undefined param passed to {logging,osmo_stats}_vty_add_cmds
......................................................................

Remove undefined param passed to {logging,osmo_stats}_vty_add_cmds

Since March 15th 2017, libosmocore API logging_vty_add_cmds() had its
parameter removed (c65c5b4ea075ef6cef11fff9442ae0b15c1d6af7). However,
definition in C file doesn't contain "(void)", which means number of
parameters is undefined and thus compiler doesn't complain. Let's remove
parameters from all callers before enforcing "(void)" on it.
API osmo_stats_vty_add_cmds never had a param list but has seem problem
(no "void"), so some users decided to pass a parameter to it.

Change-Id: Ie519d4a4064a95803c33fd6969b53e1ef27045b7
Related: OS#4138
---
M src/main.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs/changes/49/15049/1

diff --git a/src/main.c b/src/main.c
index ab58a52..13fdd5d 100644
--- a/src/main.c
+++ b/src/main.c
@@ -133,8 +133,8 @@
 	osmo_stats_init(tall_mncc_ctx);
 
 	mncc_sip_vty_init();
-	logging_vty_add_cmds(&mncc_sip_info);
-	osmo_stats_vty_add_cmds(&mncc_sip_info);
+	logging_vty_add_cmds();
+	osmo_stats_vty_add_cmds();
 
 
 	/* parsing and setup */

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15049
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: Ie519d4a4064a95803c33fd6969b53e1ef27045b7
Gerrit-Change-Number: 15049
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190805/57720885/attachment.html>


More information about the gerrit-log mailing list