Change in ...osmo-iuh[master]: Remove undefined param passed to {logging, osmo_stats}_vty_add_cmds

pespin gerrit-no-reply at lists.osmocom.org
Mon Aug 5 12:50:14 UTC 2019


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15041


Change subject: Remove undefined param passed to {logging,osmo_stats}_vty_add_cmds
......................................................................

Remove undefined param passed to {logging,osmo_stats}_vty_add_cmds

Since March 15th 2017, libosmocore API logging_vty_add_cmds() had its
parameter removed (c65c5b4ea075ef6cef11fff9442ae0b15c1d6af7). However,
definition in C file doesn't contain "(void)", which means number of
parameters is undefined and thus compiler doesn't complain. Let's remove
parameters from all callers before enforcing "(void)" on it.

Change-Id: I31a286bebe3229671d9960ae32a753d260a26b1d
Related: OS#4138
---
M src/hnbgw.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/41/15041/1

diff --git a/src/hnbgw.c b/src/hnbgw.c
index fa655ae..3f94a01 100644
--- a/src/hnbgw.c
+++ b/src/hnbgw.c
@@ -539,7 +539,7 @@
 	osmo_ss7_vty_init_asp(tall_hnb_ctx);
 	osmo_sccp_vty_init();
 	hnbgw_vty_init(g_hnb_gw, tall_hnb_ctx);
-	logging_vty_add_cmds(&hnbgw_log_info);
+	logging_vty_add_cmds();
 
 	/* Handle options after vty_init(), for --version */
 	handle_options(argc, argv);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15041
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I31a286bebe3229671d9960ae32a753d260a26b1d
Gerrit-Change-Number: 15041
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190805/036b47a5/attachment.html>


More information about the gerrit-log mailing list