This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/15031 ) Change subject: Makefile.asciidoc.inc: warnings check not default ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/15031/1/build/Makefile.asciidoc.inc File build/Makefile.asciidoc.inc: https://gerrit.osmocom.org/#/c/15031/1/build/Makefile.asciidoc.inc@79 PS1, Line 79: if [ -n "$$ASCIIDOC_WARNINGS_CHECK" ]; then \ > What's the point on having this? simply don't run make check then, right? I guess the ratioanle is that "make check" currently only relates to whether our unit tests pass. If we make it cover the documentation, particularly warnings in documentation, I'm sure that some years down the road asciidoc has more warnings than today, and you wouldn't be able to pass a "make check" anymore, which in turn makes people believe that the software is somehow broken. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/15031 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Iac993a0d1b17205397a1f1ef1a7bd3f9df739e36 Gerrit-Change-Number: 15031 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at gnumonks.org> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Sat, 03 Aug 2019 07:42:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190803/2c0df897/attachment.htm>