Change in ...osmo-bts[master]: osmo-bts-trx: migrate to new generic ECU abstraction

laforge gerrit-no-reply at lists.osmocom.org
Thu Aug 1 19:14:11 UTC 2019


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15027 )

Change subject: osmo-bts-trx: migrate to new generic ECU abstraction
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/15027/1/src/osmo-bts-trx/scheduler_trx.c 
File src/osmo-bts-trx/scheduler_trx.c:

https://gerrit.osmocom.org/#/c/15027/1/src/osmo-bts-trx/scheduler_trx.c@1304 
PS1, Line 1304: /* Feed frame into ECU */
              : 	if (lchan->ecu_state)
              : 		osmo_ecu_frame_in(lchan->ecu_state, bfi_flag, tch_data, rc);
frame_in must be called for good and bad frames, but this condition is not fulfilled here. needs rework. Control flow of this function sucks.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15027
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I001005aae6de76d4e045b8dc572239f057bb150d
Gerrit-Change-Number: 15027
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Comment-Date: Thu, 01 Aug 2019 19:14:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190801/204d5e59/attachment.html>


More information about the gerrit-log mailing list