Change in ...osmo-msc[master]: minor comments in msc_vty.c

laforge gerrit-no-reply at lists.osmocom.org
Thu Aug 1 18:58:16 UTC 2019


laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-msc/+/15020 )

Change subject: minor comments in msc_vty.c
......................................................................

minor comments in msc_vty.c

Change-Id: I83d8c778190adb1e74debc8f8ddac6996de7c513
---
M src/libmsc/msc_vty.c
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c
index c75cd0e..8ef48ff 100644
--- a/src/libmsc/msc_vty.c
+++ b/src/libmsc/msc_vty.c
@@ -688,6 +688,7 @@
 #define MSC_VTY_DUMP(vty, offset, fmt, args...) \
 	vty_out(vty, "%*s" fmt, offset, "", ##args)
 
+/* Print value of a named flag, prefixed with a given amount of spaces */
 #define MSC_VTY_DUMP_FLAG(vty, offset, name, flag) \
 	MSC_VTY_DUMP(vty, offset + 2, "%s: %*s%s%s", \
 		     name, 30 - (int)strlen(name), "", \
@@ -712,6 +713,7 @@
 	}
 
 	if (dump_flags & MSC_VTY_DUMP_F_CONNECTION) {
+		/* (If msc_a exists, there *must* be a non-null msc_a->c.msub) */
 		MSC_VTY_DUMP(vty, offset, "RAN connection: %s%s",
 			     trans->msc_a ? msub_ran_conn_name(trans->msc_a->c.msub)
 					  : "(not established)",

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15020
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I83d8c778190adb1e74debc8f8ddac6996de7c513
Gerrit-Change-Number: 15020
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190801/08250fac/attachment.html>


More information about the gerrit-log mailing list