Change in ...libosmocore[master]: Workaround TLS gcc compiler bug in ARM

laforge gerrit-no-reply at lists.osmocom.org
Thu Aug 1 18:57:24 UTC 2019


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15025 )

Change subject: Workaround TLS gcc compiler bug in ARM
......................................................................


Patch Set 1: Code-Review-1

both Hoernchen and tnt have raised serious concerns about this on IRC, e.g.: 

< tnt> With O2 it looks like it calls __tls_get_addr for a "big" zone that contains all the TLS variables and then gcc manually 'indexes' in that zone to find the right one.  And it's that indexing that's incorrect. The offset it adds is wrong.

So if that's the case, then we will get random memory corruption whenver we have __thread variables no matter what their size :/


-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15025
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Icaac4b6628341effe9d488f907dc4d42897f2065
Gerrit-Change-Number: 15025
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-Comment-Date: Thu, 01 Aug 2019 18:57:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190801/cce95ce8/attachment.html>


More information about the gerrit-log mailing list