Change in ...osmo-trx[master]: lms: Drop rx_underruns rate ctr, add tx_drop_* rate ctr

pespin gerrit-no-reply at lists.osmocom.org
Thu Aug 1 11:46:08 UTC 2019


Hello Vadim Yanitskiy, daniel, laforge, Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/osmo-trx/+/14989

to look at the new patch set (#3).

Change subject: lms: Drop rx_underruns rate ctr, add tx_drop_* rate ctr
......................................................................

lms: Drop rx_underruns rate ctr, add tx_drop_* rate ctr

After discussion in [1] and further look at the code, it became obvios
rx_underrun events are not happening in general for any SDR (don't
exist), so let's drop that counter. Instead, add Tx Dropped Packet counters,
which were not accounted prior to this commit.

[1] https://github.com/osmocom/osmo-trx/commit/bde55afd29fc9aae10eb11f6515821afa39b772d

Change-Id: Iff1535c219a4695a511d383d7c4b06ef6eff959d
---
M CommonLibs/osmo_signal.h
M CommonLibs/trx_rate_ctr.cpp
M CommonLibs/trx_rate_ctr.h
M CommonLibs/trx_vty.c
M Transceiver52M/device/lms/LMSDevice.cpp
M Transceiver52M/device/lms/LMSDevice.h
M doc/manuals/chapters/counters_generated.adoc
M doc/manuals/vty/trx_vty_reference.xml
8 files changed, 105 insertions(+), 54 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/89/14989/3
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14989
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Iff1535c219a4695a511d383d7c4b06ef6eff959d
Gerrit-Change-Number: 14989
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190801/d371b532/attachment.html>


More information about the gerrit-log mailing list