Change in ...osmo-trx[master]: lms: Drop rx_underruns rate ctr, add tx_drop_* rate ctr

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

daniel gerrit-no-reply at lists.osmocom.org
Thu Aug 1 11:23:06 UTC 2019


daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14989 )

Change subject: lms: Drop rx_underruns rate ctr, add tx_drop_* rate ctr
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/14989/2/Transceiver52M/device/lms/LMSDevice.cpp 
File Transceiver52M/device/lms/LMSDevice.cpp:

https://gerrit.osmocom.org/#/c/14989/2/Transceiver52M/device/lms/LMSDevice.cpp@767 
PS2, Line 767: 		update_stream_stats_rx(i, underrun);
This should be update_stream_stats_tx(), no?
I don't see it called anywhere.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14989
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Iff1535c219a4695a511d383d7c4b06ef6eff959d
Gerrit-Change-Number: 14989
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Aug 2019 11:23:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190801/d1ca62e2/attachment.htm>


More information about the gerrit-log mailing list