Change in ...osmo-sip-connector[master]: Handle SIP re-INVITEs

keith gerrit-no-reply at lists.osmocom.org
Thu Aug 1 08:26:36 UTC 2019


keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14994 )

Change subject: Handle SIP re-INVITEs
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/#/c/14994/3/src/sip.c 
File src/sip.c:

https://gerrit.osmocom.org/#/c/14994/3/src/sip.c@189 
PS3, Line 189: 	LOGP(DSIP, LOGL_DEBUG, "Sending 200 response to re-INVITE for mode(%u)\n", mode);
> (looks like we could use a value_string array translating the modes to human-readable strings... […]
The osmo-sip-connector log is almost entirely outputting non human readable values. In a future commit, I may deal with this en mass.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14994
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: I4083ed50d0cf1b302b80354fe0c2b73fc6e14fed
Gerrit-Change-Number: 14994
Gerrit-PatchSet: 3
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at gnumonks.org>
Gerrit-Comment-Date: Thu, 01 Aug 2019 08:26:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190801/dbe1c057/attachment.html>


More information about the gerrit-log mailing list