Change in osmo-sgsn[master]: Echo XID-Field of Type L3_PAR even when zero length

Keith Whyte gerrit-no-reply at lists.osmocom.org
Tue Apr 30 09:51:14 UTC 2019


Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/13811 )

Change subject: Echo XID-Field of Type L3_PAR even when zero length
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/#/c/13811/3/src/gprs/gprs_sndcp.c
File src/gprs/gprs_sndcp.c:

https://gerrit.osmocom.org/#/c/13811/3/src/gprs/gprs_sndcp.c@1125
PS3, Line 1125: 		xid_field_response = gprs_llc_dup_xid_field(lle->llme, xid_field_indication);
this doesn't work as I don't know how to get this value back to caller.


https://gerrit.osmocom.org/#/c/13811/3/src/gprs/gprs_sndcp.c@1126
PS3, Line 1126: 		// xid_field_response->list = gprs_llc_copy_xid(lle->llme, &xid_field_indication->list);
this would seem to my mind to be going in the right direction, but it doesn't compile, because I don't know C.
@lynxis, can you help me out?



-- 
To view, visit https://gerrit.osmocom.org/13811
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd75f7b943c84ed7264481fa2e4bc3cb2f6745d4
Gerrit-Change-Number: 13811
Gerrit-PatchSet: 3
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Comment-Date: Tue, 30 Apr 2019 09:51:14 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190430/1377a306/attachment.html>


More information about the gerrit-log mailing list