Change in osmo-sgsn[master]: Echo XID-Field of Type L3_PAR even when zero length

lynxis lazus gerrit-no-reply at lists.osmocom.org
Mon Apr 29 21:31:38 UTC 2019


lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/13811 )

Change subject: Echo XID-Field of Type L3_PAR even when zero length
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.osmocom.org/#/c/13811/1/src/gprs/gprs_llc.c
File src/gprs/gprs_llc.c:

https://gerrit.osmocom.org/#/c/13811/1/src/gprs/gprs_llc.c@267
PS1, Line 267: 					xid_field_response = gprs_llc_dup_xid_field(lle->llme, xid_field);
> I don't get something here.. This is needed to echo back what the phone wants. […]
If you "echo" something backs, it means you accept the XID.
The code in this file looks correct, the layer 3 decides what do write back, if this is a L3 XID


https://gerrit.osmocom.org/#/c/13811/1/src/gprs/gprs_sndcp.c
File src/gprs/gprs_sndcp.c:

https://gerrit.osmocom.org/#/c/13811/1/src/gprs/gprs_sndcp.c@1122
PS1, Line 1122: 
Better to do here an `if (xid_field_indication->data_len == 0) gprs_llc_copy_xid()` and add a comment, that some phones actually sent zero byte length SNDCP frames.


https://gerrit.osmocom.org/#/c/13811/1/src/gprs/gprs_sndcp.c@1128
PS1, Line 1128: 	if (comp_fields == NULL)
> I suppose NULL == false.. but just in case i did it this way to test. […]
(!comp_fields) is equivalent to (comp_fields == NULL).



-- 
To view, visit https://gerrit.osmocom.org/13811
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd75f7b943c84ed7264481fa2e4bc3cb2f6745d4
Gerrit-Change-Number: 13811
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Comment-Date: Mon, 29 Apr 2019 21:31:38 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190429/695b7dfa/attachment.html>


More information about the gerrit-log mailing list