Change in osmo-gsm-tester[master]: virtual: Unify the lua script into a single one

Holger Freyther gerrit-no-reply at lists.osmocom.org
Sun Apr 28 14:50:43 UTC 2019


Holger Freyther has posted comments on this change. ( https://gerrit.osmocom.org/13804 )

Change subject: virtual: Unify the lua script into a single one
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/13804/2/src/osmo_gsm_tester/templates/osmo-mobile.lua.tmpl
File src/osmo_gsm_tester/templates/osmo-mobile.lua.tmpl:

https://gerrit.osmocom.org/#/c/13804/2/src/osmo_gsm_tester/templates/osmo-mobile.lua.tmpl@18
PS2, Line 18: 	lu_test_mm_cb(new_state, new_substate, old_substate)
> shouldn't the %if and %endif stuff be here instead of the concrete function?
Sure. I can move it here but then the above must always be well defined.



-- 
To view, visit https://gerrit.osmocom.org/13804
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a093671173976eba9215c00a7aea0f6cab467c6
Gerrit-Change-Number: 13804
Gerrit-PatchSet: 2
Gerrit-Owner: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Sun, 28 Apr 2019 14:50:43 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190428/2e0187c3/attachment.html>


More information about the gerrit-log mailing list