Change in osmo-gsm-tester[master]: virtual: Have a single result class that can store data

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Sun Apr 28 14:37:36 UTC 2019


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13805 )

Change subject: virtual: Have a single result class that can store data
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/13805/2/src/osmo_ms_driver/test_support.py
File src/osmo_ms_driver/test_support.py:

https://gerrit.osmocom.org/#/c/13805/2/src/osmo_ms_driver/test_support.py@29
PS2, Line 29: class Result(log.Origin):
That's more like a ResultStorage or ResultStore right? Result which actually contains a set of different results is really confusing.



-- 
To view, visit https://gerrit.osmocom.org/13805
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie99351bee1515de8cf6870467f08256a53701907
Gerrit-Change-Number: 13805
Gerrit-PatchSet: 2
Gerrit-Owner: Holger Freyther <holger at freyther.de>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Sun, 28 Apr 2019 14:37:36 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190428/021cce52/attachment.html>


More information about the gerrit-log mailing list