Change in osmo-sgsn[master]: LLC: Avoid NOTICE message on LLC NULL

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Apr 24 13:40:08 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13765 )

Change subject: LLC: Avoid NOTICE message on LLC NULL
......................................................................

LLC: Avoid NOTICE message on LLC NULL

A MS sending LLC NULL frames on cell change is a perfectly normal event,
and we shouldn't log any cryptic NOTICE messages about it.

Change-Id: I6be0b9c8813dfb40a7955422fd8e7cebf94d189c
---
M src/gprs/gprs_llc.c
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved
  Keith Whyte: Looks good to me, but someone else must approve
  Pau Espin Pedrol: Looks good to me, approved



diff --git a/src/gprs/gprs_llc.c b/src/gprs/gprs_llc.c
index c222bc2..654f2c0 100644
--- a/src/gprs/gprs_llc.c
+++ b/src/gprs/gprs_llc.c
@@ -860,6 +860,9 @@
 		if ((gph->seq_tx + 1) / 512)
 			lle->oc_ui_recv += 512;
 		break;
+	case GPRS_LLC_NULL:
+		LOGP(DLLC, LOGL_DEBUG, "TLLI=%08x sends us LLC NULL\n", lle->llme ? lle->llme->tlli : -1);
+		break;
 	default:
 		LOGP(DLLC, LOGL_NOTICE, "Unhandled command: %d\n", gph->cmd);
 		break;

-- 
To view, visit https://gerrit.osmocom.org/13765
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6be0b9c8813dfb40a7955422fd8e7cebf94d189c
Gerrit-Change-Number: 13765
Gerrit-PatchSet: 3
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190424/83c7e63b/attachment.html>


More information about the gerrit-log mailing list