Change in osmo-sgsn[master]: gprs_gmm: send Service Reject when no PDP ctxs are available.
gerrit-no-reply at lists.osmocom.org
Wed Apr 24 12:09:15 UTC 2019
Mykola Shchetinin has posted comments on this change. ( https://gerrit.osmocom.org/13744 )
Change subject: gprs_gmm: send Service Reject when no PDP ctxs are available.
Patch Set 6:
PS5, Line 1620: * network.
> Please also leave the old comment together with the new additions, it's handy to understand what the […]
PS5, Line 1628: size_t i;
> Probably much clear to have simple pdp_nsapi++ in the foor loop clause, then in body have: […]
Yes, I should have used "i" for indexing pdp_status.
"i" is also used in the loop condition, so it is better to leave it there.
I could put it in the end of the loop, but then due to "continue" it doesn't get changed always.
To view, visit https://gerrit.osmocom.org/13744
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Owner: Mykola Shchetinin <mykola at pentonet.com>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Mykola Shchetinin <mykola at pentonet.com>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 24 Apr 2019 12:09:15 +0000
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the gerrit-log