Change in osmo-sgsn[master]: LLC: Don't blindly assume all LLC frames have data payload

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Wed Apr 24 09:16:59 UTC 2019


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13764 )

Change subject: LLC: Don't blindly assume all LLC frames have data payload
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/13764/2/src/gprs/gprs_llc.c
File src/gprs/gprs_llc.c:

https://gerrit.osmocom.org/#/c/13764/2/src/gprs/gprs_llc.c@961
PS2, Line 961: 		/* set l3 layer & remove the fcs */
> there is FCS in any LLC frame, as the FCS covers both header and payload, right? […]
Makes sense, thanks for the explanation.



-- 
To view, visit https://gerrit.osmocom.org/13764
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I51bbd0f2c618d477a037af343ff41de1c8a5a3ae
Gerrit-Change-Number: 13764
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 24 Apr 2019 09:16:59 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190424/5eb240a2/attachment.html>


More information about the gerrit-log mailing list