Change in osmo-bts[master]: common/paging.c: fix unaligned pointer access

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Apr 24 08:49:26 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13769 )

Change subject: common/paging.c: fix unaligned pointer access
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/13769/1/src/common/paging.c
File src/common/paging.c:

https://gerrit.osmocom.org/#/c/13769/1/src/common/paging.c@305
PS1, Line 305: 	uint32_t tmsi1, tmsi2;
you could have simply used one "uint32_t tmsi_tmp" variable, 
as you never use multiple of them in parallell.

I hope compilers are good enough these days to notice those variables are not all used in parallel.



-- 
To view, visit https://gerrit.osmocom.org/13769
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief69854973a098e6da7c05f4417dc11988edd777
Gerrit-Change-Number: 13769
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Wed, 24 Apr 2019 08:49:26 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190424/01b8fa3e/attachment.html>


More information about the gerrit-log mailing list