Change in osmo-bts[master]: common/oml.c: fix: properly encode NM_ATT_SW_CONFIG

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Tue Apr 23 19:29:04 UTC 2019


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13709 )

Change subject: common/oml.c: fix: properly encode NM_ATT_SW_CONFIG
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/#/c/13709/2/src/common/oml.c
File src/common/oml.c:

https://gerrit.osmocom.org/#/c/13709/2/src/common/oml.c@164
PS2, Line 164: 	*len = htons(total_len);
better use osmo_store16be, len may not be aligned?


https://gerrit.osmocom.org/#/c/13709/2/src/common/oml.c@190
PS2, Line 190: 	*len = htons(total_len);
same as comment above.



-- 
To view, visit https://gerrit.osmocom.org/13709
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id26104719891944f3e2151df362bd45bb057a9c5
Gerrit-Change-Number: 13709
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Tue, 23 Apr 2019 19:29:04 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190423/8a65ecdd/attachment.html>


More information about the gerrit-log mailing list