Change in osmo-bts[master]: osmo-bts-trx: distinguish 11-bit Access Bursts by synch. sequence

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Tue Apr 23 18:56:08 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13723 )

Change subject: osmo-bts-trx: distinguish 11-bit Access Bursts by synch. sequence
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/#/c/13723/4/src/osmo-bts-trx/scheduler_trx.c
File src/osmo-bts-trx/scheduler_trx.c:

https://gerrit.osmocom.org/#/c/13723/4/src/osmo-bts-trx/scheduler_trx.c@750
PS4, Line 750: 	(synch_seq_ref[i][j] == '1' ? -1 : 1)
> Why not just have an array of 1/-1's instead of a string? This is probably not a very hot code path  […]
In general, I am agree. This adds one cmp and a few more instructions to the loop (at least in GDB 4.8, Clang 8 somehow avoids them). But IMHO, strings in this particular case look way more readable and closer to the specs, than an array of +1/-1. Access Bursts are not as frequent as Normal Bursts, for example, so there should be no valuable performance impact.



-- 
To view, visit https://gerrit.osmocom.org/13723
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb6d27c6589965c8b59a6d2598a7c43fd860f284
Gerrit-Change-Number: 13723
Gerrit-PatchSet: 4
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Alexander Chemeris <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Tue, 23 Apr 2019 18:56:08 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190423/c32dc4ba/attachment.htm>


More information about the gerrit-log mailing list