Change in osmo-msc[master]: vlr_sgs_fsm: make sure vsub is marked used when LA is present

dexter gerrit-no-reply at lists.osmocom.org
Tue Apr 23 11:32:08 UTC 2019


dexter has submitted this change and it was merged. ( https://gerrit.osmocom.org/13690 )

Change subject: vlr_sgs_fsm: make sure vsub is marked used when LA is present
......................................................................

vlr_sgs_fsm: make sure vsub is marked used when LA is present

When the LU is accepted and the subscriber (vsub) is not claimed as "in
use" in the ref counting system.

- Make sure vlr_subscr_get() is called when the LU is accepted.

Change-Id: Iba90be095569cc5212c61ab8e8a9bfd4ae51fd44
Related OS#3934
---
M src/libvlr/vlr_sgs_fsm.c
1 file changed, 7 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Daniel Willmann: Looks good to me, but someone else must approve
  dexter: Looks good to me, approved



diff --git a/src/libvlr/vlr_sgs_fsm.c b/src/libvlr/vlr_sgs_fsm.c
index ee1d748..a25d41c 100644
--- a/src/libvlr/vlr_sgs_fsm.c
+++ b/src/libvlr/vlr_sgs_fsm.c
@@ -128,7 +128,13 @@
 		vsub->loc_conf_in_hlr_ind = true;
 		vsub->la_allowed = true;
 		vsub->imsi_detached_flag = false;
-		vsub->lu_complete = true;
+
+		if (!vsub->lu_complete) {
+			vsub->lu_complete = true;
+			/* Balanced by vlr_subscr_expire() */
+			vlr_subscr_get(vsub, VSUB_USE_ATTACHED);
+		}
+
 		vlr_sgs_fsm_update_id(vsub);
 		vsub->cs.attached_via_ran = OSMO_RAT_EUTRAN_SGS;
 

-- 
To view, visit https://gerrit.osmocom.org/13690
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iba90be095569cc5212c61ab8e8a9bfd4ae51fd44
Gerrit-Change-Number: 13690
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Assignee: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Daniel Willmann <dwillmann at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190423/0922ff1b/attachment.html>


More information about the gerrit-log mailing list