Change in osmo-mgw[master]: mgcp_msg: Log faulty line on Osmux parsing error

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Tue Apr 23 11:25:12 UTC 2019


Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/13743


Change subject: mgcp_msg: Log faulty line on Osmux parsing error
......................................................................

mgcp_msg: Log faulty line on Osmux parsing error

Change-Id: I436e53963f8e7d00f3111ff81f7b08475c4b8ae9
---
M src/libosmo-mgcp/mgcp_msg.c
1 file changed, 4 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/43/13743/1

diff --git a/src/libosmo-mgcp/mgcp_msg.c b/src/libosmo-mgcp/mgcp_msg.c
index f98b9ee..5844d41 100644
--- a/src/libosmo-mgcp/mgcp_msg.c
+++ b/src/libosmo-mgcp/mgcp_msg.c
@@ -365,8 +365,11 @@
 {
 	int osmux_cid;
 
-	if (sscanf(line + 2, "Osmux: %u", &osmux_cid) != 1)
+	if (sscanf(line + 2, "Osmux: %u", &osmux_cid) != 1) {
+		LOGP(DLMGCP, LOGL_ERROR, "Failed parsing Osmux in MGCP msg line: %s\n",
+		     line);
 		return -1;
+	}
 
 	if (osmux_cid > OSMUX_CID_MAX) {
 		LOGP(DLMGCP, LOGL_ERROR, "Osmux ID too large: %u > %u\n",

-- 
To view, visit https://gerrit.osmocom.org/13743
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I436e53963f8e7d00f3111ff81f7b08475c4b8ae9
Gerrit-Change-Number: 13743
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190423/f57cc125/attachment.html>


More information about the gerrit-log mailing list