Change in osmo-ttcn3-hacks[master]: f_perform_lu(): Use f_expect_clear(), reduce code duplication

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Apr 22 13:08:13 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13729 )

Change subject: f_perform_lu(): Use f_expect_clear(), reduce code duplication
......................................................................

f_perform_lu(): Use f_expect_clear(), reduce code duplication

Change-Id: I64b183ad6615f2b0b9565a711de87fe4249625a1
---
M msc/BSC_ConnectionHandler.ttcn
1 file changed, 1 insertion(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn
index b3345ff..db0e683 100644
--- a/msc/BSC_ConnectionHandler.ttcn
+++ b/msc/BSC_ConnectionHandler.ttcn
@@ -384,9 +384,7 @@
 	f_expect_mm_info();
 
 	/* FIXME: there could be pending SMS or other common procedures by the MSC, let's ignore them */
-	BSSAP.receive(tr_BSSMAP_ClearCommand);
-	BSSAP.send(ts_BSSMAP_ClearComplete);
-	BSSAP.receive(RAN_Conn_Prim:MSC_CONN_PRIM_DISC_IND);
+	f_expect_clear();
 	setverdict(pass);
 }
 

-- 
To view, visit https://gerrit.osmocom.org/13729
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I64b183ad6615f2b0b9565a711de87fe4249625a1
Gerrit-Change-Number: 13729
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190422/3831dbd2/attachment.html>


More information about the gerrit-log mailing list