Change in osmo-bts[master]: common/oml.c: constify argument 'trx' of handle_attrs_trx()

Harald Welte gerrit-no-reply at
Sun Apr 21 08:06:37 UTC 2019

Harald Welte has submitted this change and it was merged. ( )

Change subject: common/oml.c: constify argument 'trx' of handle_attrs_trx()

common/oml.c: constify argument 'trx' of handle_attrs_trx()

Change-Id: Id476d492b3c1d0c728fca9eb0fb2254512bdef72
M include/osmo-bts/phy_link.h
M src/common/oml.c
2 files changed, 3 insertions(+), 3 deletions(-)

  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

diff --git a/include/osmo-bts/phy_link.h b/include/osmo-bts/phy_link.h
index 2472c05..812f186 100644
--- a/include/osmo-bts/phy_link.h
+++ b/include/osmo-bts/phy_link.h
@@ -166,7 +166,7 @@
 void phy_user_statechg_notif(struct phy_instance *pinst, enum phy_link_state link_state);
-static inline struct phy_instance *trx_phy_instance(struct gsm_bts_trx *trx)
+static inline struct phy_instance *trx_phy_instance(const struct gsm_bts_trx *trx)
 	return trx->role_bts.l1h;
diff --git a/src/common/oml.c b/src/common/oml.c
index 80d424f..03fdc56 100644
--- a/src/common/oml.c
+++ b/src/common/oml.c
@@ -155,7 +155,7 @@
 	msgb_tl16v_put(msg, NM_ATT_MANUF_ID, _NUM_BTS_FEAT/8 + 1, bts->_features_data);
-static inline void add_trx_attr(struct msgb *msg, struct gsm_bts_trx *trx)
+static inline void add_trx_attr(struct msgb *msg, const struct gsm_bts_trx *trx)
 	const struct phy_instance *pinst = trx_phy_instance(trx);
@@ -191,7 +191,7 @@
 	return len + out_offset + 1;
-static inline int handle_attrs_trx(uint8_t *out, struct gsm_bts_trx *trx, const uint8_t *attr, uint16_t attr_len)
+static inline int handle_attrs_trx(uint8_t *out, const struct gsm_bts_trx *trx, const uint8_t *attr, uint16_t attr_len)
 	uint16_t i, attr_out_index = 1; /* byte 0 is reserved for unsupported attributes counter */
 	struct msgb *attr_buf = oml_msgb_alloc();

To view, visit
To unsubscribe, or for help writing mail filters, visit

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id476d492b3c1d0c728fca9eb0fb2254512bdef72
Gerrit-Change-Number: 13699
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy <axilirator at>
Gerrit-Reviewer: Harald Welte <laforge at>
Gerrit-Reviewer: Jenkins Builder (1000002)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the gerrit-log mailing list