Change in osmo-bts[master]: common/oml.c: fix: properly encode NM_ATT_SW_CONFIG

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Fri Apr 19 20:58:57 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13709 )

Change subject: common/oml.c: fix: properly encode NM_ATT_SW_CONFIG
......................................................................


Patch Set 2:

> did you check how this is with a nanoBTS?

I saw a few comments in OsmoBSC stating that nanoBTS is using a non-standard (spec. violating) attribute formatting. This can be also seen looking at the captures from OS#3814.

> I think it's best to align with how they implement this.

Not sure if it's a good idea to replicate such vendor-specific behaviour.
The current patch follows what the specs. recommend to follow...

> Also, the big question is what we do in terms of compatibility.
> Maybe add it twice: both in the correct and in the incorrect form?

Of course we can do that. But I would rather write a fix for OpenBSC.


-- 
To view, visit https://gerrit.osmocom.org/13709
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id26104719891944f3e2151df362bd45bb057a9c5
Gerrit-Change-Number: 13709
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Fri, 19 Apr 2019 20:58:57 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190419/5c37fca4/attachment.html>


More information about the gerrit-log mailing list