Change in osmo-bts[master]: common/oml.c: refactor Get Attribute Response message generation
gerrit-no-reply at lists.osmocom.org
Fri Apr 19 19:07:39 UTC 2019
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13708 )
Change subject: common/oml.c: refactor Get Attribute Response message generation
Patch Set 1:
PS1, Line 194: static inline int handle_attrs_trx(struct msgb *msg, const struct gsm_bts_trx *trx,
> in terms of naming, this could be 'out' or 'msg_out' or 'resp' to indicate clearly that it's the out […]
Good point. I think it makes more sense to rename the symbol itself, as we don't actually 'handle' any attributes on the BTS. A proper self-explaining symbol name would be 'encode_attrs_trx' or 'put_attrs_trx'.
PS1, Line 214: /* Push this tag to the list of unreported attributes */
> what are "unreported" attributes? I think you can report somethng, but how can you un-report it aga […]
It's my poor English ;) Though this word can be seen in the existing code of both OsmoBSC and OsmoBTS. The specs. are using 'non-reported' term.
This is about OML attributes that are not supported by the MO. As per 3GPP TS 52.021, if an attribute is not supported, it shall be included in the Get Attribute response anyway, as a part of 'non-reported' attribute list.
To view, visit https://gerrit.osmocom.org/13708
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Fri, 19 Apr 2019 19:07:39 +0000
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the gerrit-log