Change in osmo-mgw[master]: move MGW endpoint FSM from osmo-bsc to here

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Apr 19 16:05:52 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13590 )

Change subject: move MGW endpoint FSM from osmo-bsc to here
......................................................................


Patch Set 3:

I like this move (both literally and in abstract sense).  However, no matter how much pressure we have in terms of getting features complete, I think it's not a good way to merge new library code without doxygen documentation.  Or at least some API documentation on top of the function declearations/definitions at all.  This is not some code that is internal to a given sub-system, but it's a "public" API that programs (and hence programmers) are supposed to use, and hence it deserves API docs, IMHO.


-- 
To view, visit https://gerrit.osmocom.org/13590
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a3effd38e72841529df6c135c077116981dea36
Gerrit-Change-Number: 13590
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Fri, 19 Apr 2019 16:05:52 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190419/08a581af/attachment.html>


More information about the gerrit-log mailing list