Change in osmo-sip-connector[master]: MNCC: Do not continue with B leg if A leg is cancelled.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Apr 19 16:01:20 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11194 )

Change subject: MNCC: Do not continue with B leg if A leg is cancelled.
......................................................................


Patch Set 2:

> > I only tested it against my new TTCN3 unit test very briefly.
 > > @Keith: If you would have time to test it with your manual test
 > > case, we could be 100% sure.
 > 
 > Harald, I wrote a simple automated test to reproduce the issue with
 > a calypso board by issuing the ATD command and the ATH after 0.5s.
 > I can test here too.

Thanks. Whichever way, for sure it's good to have it tested somehow beyond the TTCN-3 test which I wrote (but I've not seen the real issue in the real world, so my test might be wrong).


-- 
To view, visit https://gerrit.osmocom.org/11194
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0eca9a741f7924c2fc32c503dd1a0fc083f94f37
Gerrit-Change-Number: 11194
Gerrit-PatchSet: 2
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Rafael Diniz <rafael at rhizomatica.org>
Gerrit-Comment-Date: Fri, 19 Apr 2019 16:01:20 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190419/b7e854da/attachment.html>


More information about the gerrit-log mailing list