Change in osmo-bts[master]: common/oml.c: use proper OML object for Get Attribute Response

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Fri Apr 19 12:24:44 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13701 )

Change subject: common/oml.c: use proper OML object for Get Attribute Response
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/13701/1/src/common/oml.c
File src/common/oml.c:

https://gerrit.osmocom.org/#/c/13701/1/src/common/oml.c@272
PS1, Line 272: 		len = handle_attrs_bts(resp, (const struct gsm_bts *) obj, attr, attr_len);
> If you know it's going to be BTS, then just pass mo->bts and avoid nasty castings.
Done.


https://gerrit.osmocom.org/#/c/13701/1/src/common/oml.c@275
PS1, Line 275: 		len = handle_attrs_trx(resp, (const struct gsm_bts_trx *) obj, attr, attr_len);
> Are yousure this is correct? gsm_objclass2obj returns &trx->bb_transc here, not trx.
You're right, thanks! Fixed.



-- 
To view, visit https://gerrit.osmocom.org/13701
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb1ee75d4bf680deb6365288d8c2053816a12217
Gerrit-Change-Number: 13701
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 19 Apr 2019 12:24:44 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190419/4c07b8e3/attachment.html>


More information about the gerrit-log mailing list