Change in osmo-ccid-firmware[master]: remove SWO pin initialisation

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Apr 17 10:10:25 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13674 )

Change subject: remove SWO pin initialisation
......................................................................

remove SWO pin initialisation

using the SWO signal on TX has the advantage of being able to
have printf debug while still using SERCOM7 in ISO7816 mode for
the SIM card, but it has two drawbacks:
- SWO outputs data only if a debug session is ongoing (e.g. a SWD
debugger is connected). this saves output processing when no SWD
is connected, but it is not possible to force output without
having an SWD debugger connect (confirmed by Microchip help),
which is not convenient for simple UART debugging.
- no input is possible (SWO can only output).

Thus instead we will still use SERCOM7 for UART debug, allowing
commands to be input.
SERCOM7 should only be used for UART debug when no card in present
in SIM7.
This check in not yet implemented.

Change-Id: I199d6e356129526e65d5d1075a264eb35904d099
---
M sysmoOCTSIM/driver_init.c
1 file changed, 0 insertions(+), 47 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/sysmoOCTSIM/driver_init.c b/sysmoOCTSIM/driver_init.c
index 06184ee..726129d 100644
--- a/sysmoOCTSIM/driver_init.c
+++ b/sysmoOCTSIM/driver_init.c
@@ -702,53 +702,6 @@
 
 	gpio_set_pin_function(SDA1, GPIO_PIN_FUNCTION_OFF);
 
-	// GPIO on PB30
-
-	gpio_set_pin_direction(UART_TX,
-	                       // <y> Pin direction
-	                       // <id> pad_direction
-	                       // <GPIO_DIRECTION_OFF"> Off
-	                       // <GPIO_DIRECTION_IN"> In
-	                       // <GPIO_DIRECTION_OUT"> Out
-	                       GPIO_DIRECTION_OUT);
-
-	gpio_set_pin_level(UART_TX,
-	                   // <y> Initial level
-	                   // <id> pad_initial_level
-	                   // <false"> Low
-	                   // <true"> High
-	                   false);
-
-	gpio_set_pin_pull_mode(UART_TX,
-	                       // <y> Pull configuration
-	                       // <id> pad_pull_config
-	                       // <GPIO_PULL_OFF"> Off
-	                       // <GPIO_PULL_UP"> Pull-up
-	                       // <GPIO_PULL_DOWN"> Pull-down
-	                       GPIO_PULL_OFF);
-
-	gpio_set_pin_function(UART_TX,
-	                      // <y> Pin function
-	                      // <id> pad_function
-	                      // <i> Auto : use driver pinmux if signal is imported by driver, else turn off function
-	                      // <GPIO_PIN_FUNCTION_OFF"> Auto
-	                      // <GPIO_PIN_FUNCTION_OFF"> Off
-	                      // <GPIO_PIN_FUNCTION_A"> A
-	                      // <GPIO_PIN_FUNCTION_B"> B
-	                      // <GPIO_PIN_FUNCTION_C"> C
-	                      // <GPIO_PIN_FUNCTION_D"> D
-	                      // <GPIO_PIN_FUNCTION_E"> E
-	                      // <GPIO_PIN_FUNCTION_F"> F
-	                      // <GPIO_PIN_FUNCTION_G"> G
-	                      // <GPIO_PIN_FUNCTION_H"> H
-	                      // <GPIO_PIN_FUNCTION_I"> I
-	                      // <GPIO_PIN_FUNCTION_J"> J
-	                      // <GPIO_PIN_FUNCTION_K"> K
-	                      // <GPIO_PIN_FUNCTION_L"> L
-	                      // <GPIO_PIN_FUNCTION_M"> M
-	                      // <GPIO_PIN_FUNCTION_N"> N
-	                      GPIO_PIN_FUNCTION_H);
-
 	// GPIO on PC00
 
 	// Set pin direction to input

-- 
To view, visit https://gerrit.osmocom.org/13674
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I199d6e356129526e65d5d1075a264eb35904d099
Gerrit-Change-Number: 13674
Gerrit-PatchSet: 7
Gerrit-Owner: Kévin Redon <kredon at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190417/2808c7ce/attachment.html>


More information about the gerrit-log mailing list