Change in osmo-trx[master]: lms: move LMS_GetLPFBWRange and LMS_Calibrate calls from open to start

roh gerrit-no-reply at lists.osmocom.org
Tue Apr 16 21:32:40 UTC 2019


roh has posted comments on this change. ( https://gerrit.osmocom.org/13662 )

Change subject: lms: move LMS_GetLPFBWRange and LMS_Calibrate calls from open to start
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/13662/2/Transceiver52M/device/lms/LMSDevice.cpp
File Transceiver52M/device/lms/LMSDevice.cpp:

https://gerrit.osmocom.org/#/c/13662/2/Transceiver52M/device/lms/LMSDevice.cpp@373
PS2, Line 373: 	lpfbw_tx = OSMO_MIN(OSMO_MAX(5.2e6, range_lpfbw_tx.min), range_lpfbw_tx.max);
> You forgot to apply my last comments regarding this section. […]
i actually would like to keep it this way.
otherwise i'll need to have the whole bw calculation inside whatever calls do_filters.
also do_filters is not simpler if it would have 2 more parameters (dir_tx and lpfwbw)



-- 
To view, visit https://gerrit.osmocom.org/13662
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1090effdf0f43e5183a402e4c1a1ffe5abdefd37
Gerrit-Change-Number: 13662
Gerrit-PatchSet: 2
Gerrit-Owner: roh <jsteiger at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: roh <jsteiger at sysmocom.de>
Gerrit-Comment-Date: Tue, 16 Apr 2019 21:32:40 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190416/b9e0359a/attachment.html>


More information about the gerrit-log mailing list