Change in gr-gsm[master]: grgsm_capture: Fix device arguments

Vasil Velichkov gerrit-no-reply at lists.osmocom.org
Tue Apr 16 19:34:51 UTC 2019


Hello Piotr Krysik, Vadim Yanitskiy,

I'd like you to do a code review. Please visit

    https://gerrit.osmocom.org/13672

to review the following change.


Change subject: grgsm_capture: Fix device arguments
......................................................................

grgsm_capture: Fix device arguments

We need a space between numchan=1 and the rest of the device arguments
otherwise when --args is specified it fails with RuntimeError: bad lexical cast

$ grgsm_capture --args=soapy

Traceback (most recent call last):
  File "/usr/local/bin/grgsm_capture", line 179, in <module>
    device_args=options.device_args)
  File "/usr/local/bin/grgsm_capture", line 57, in __init__
    osmosdr.source(args="numchan=1" + device_args )
  File "/usr/local/lib64/python2.7/site-packages/osmosdr/osmosdr_swig.py", line 1170, in make
    return _osmosdr_swig.source_make(*args, **kwargs)
RuntimeError: bad lexical cast: source type value could not be interpreted as target

Change-Id: I2d1bcee835b695c91a5c44ec78a40b2d969f611c
---
M apps/helpers/grgsm_capture
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/gr-gsm refs/changes/72/13672/1

diff --git a/apps/helpers/grgsm_capture b/apps/helpers/grgsm_capture
index f698205..081544a 100755
--- a/apps/helpers/grgsm_capture
+++ b/apps/helpers/grgsm_capture
@@ -54,7 +54,8 @@
         ##################################################
 
         self.sdr_source = \
-                    osmosdr.source(args="numchan=1" + device_args )
+                    osmosdr.source(args="numchan=" + str(1) + " " + device_args)
+
         self.sdr_source.set_sample_rate(samp_rate)
         self.sdr_source.set_center_freq(freq, 0)
         self.sdr_source.set_freq_corr(freq_corr, 0)

-- 
To view, visit https://gerrit.osmocom.org/13672
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: gr-gsm
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2d1bcee835b695c91a5c44ec78a40b2d969f611c
Gerrit-Change-Number: 13672
Gerrit-PatchSet: 1
Gerrit-Owner: Vasil Velichkov <vvvelichkov at gmail.com>
Gerrit-Reviewer: Piotr Krysik <ptrkrysik at gmail.com>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190416/aa4c873f/attachment.html>


More information about the gerrit-log mailing list