Change in osmo-trx[master]: move LMS_EnableChannel from Start/Stop to Open/Close device

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Tue Apr 16 15:43:49 UTC 2019


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13661 )

Change subject: move LMS_EnableChannel from Start/Stop to Open/Close device
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/13661/1/Transceiver52M/device/lms/LMSDevice.cpp
File Transceiver52M/device/lms/LMSDevice.cpp:

https://gerrit.osmocom.org/#/c/13661/1/Transceiver52M/device/lms/LMSDevice.cpp@203
PS1, Line 203: 	/* enable all used channels */
Add short explanation why this needs to be done the first, to avoid people in the future moving it someone else without knowing about possible restrictions.



-- 
To view, visit https://gerrit.osmocom.org/13661
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82878913254ce15a85db8d006e13d5eb639793e9
Gerrit-Change-Number: 13661
Gerrit-PatchSet: 1
Gerrit-Owner: roh <jsteiger at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 16 Apr 2019 15:43:49 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190416/54b0d098/attachment.html>


More information about the gerrit-log mailing list