Change in osmo-ttcn3-hacks[master]: BSSMAP_Emulation: Check for ==/!= null instead of isvalue()

dexter gerrit-no-reply at lists.osmocom.org
Tue Apr 16 07:24:14 UTC 2019


dexter has submitted this change and it was merged. ( https://gerrit.osmocom.org/13648 )

Change subject: BSSMAP_Emulation: Check for ==/!= null instead of isvalue()
......................................................................

BSSMAP_Emulation: Check for ==/!= null instead of isvalue()

Related: OS#3932
Change-Id: I2434c776c6a4ee83e97bc04e7cbbaf1b546731c0
---
M library/BSSMAP_Emulation.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  dexter: Looks good to me, but someone else must approve; Verified
  Harald Welte: Looks good to me, approved



diff --git a/library/BSSMAP_Emulation.ttcn b/library/BSSMAP_Emulation.ttcn
index 55ce2fb..3816ed7 100644
--- a/library/BSSMAP_Emulation.ttcn
+++ b/library/BSSMAP_Emulation.ttcn
@@ -406,7 +406,7 @@
 		var BSSAP_ConnHdlr client := null;
 		client := f_imsi_table_find(bssap.pdu.bssmap.paging.iMSI.digits,
 					   bssap.pdu.bssmap.paging.tMSI.tmsiOctets);
-		if (isvalue(client)) {
+		if (client != null) {
 			log("CommonBssmapUnitdataCallback: IMSI/TMSI found in table, dispatching to ",
 				client);
 			CLIENT.send(bssap) to client;

-- 
To view, visit https://gerrit.osmocom.org/13648
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2434c776c6a4ee83e97bc04e7cbbaf1b546731c0
Gerrit-Change-Number: 13648
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Willmann <dwillmann at sysmocom.de>
Gerrit-Reviewer: Daniel Willmann <dwillmann at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190416/adbe21d2/attachment.html>


More information about the gerrit-log mailing list