Change in osmo-msc[master]: Introduce initial unit test for db_sms_* API

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Mon Apr 15 15:03:22 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13629 )

Change subject: Introduce initial unit test for db_sms_* API
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/13629/1/tests/db_sms/Makefile.am
File tests/db_sms/Makefile.am:

https://gerrit.osmocom.org/#/c/13629/1/tests/db_sms/Makefile.am@47
PS1, Line 47: 	-lrt \
> why is -lrt needed?
TBH, I just copy-pasted the whole Makefile.am from the 'sms_queue' test. It's also used in the 'msc_vlr'.

Not sure if we really need this... OsmoMSC builds (and passes all tests) just fine without this library.


https://gerrit.osmocom.org/#/c/13629/1/tests/db_sms/db_sms_test.c
File tests/db_sms/db_sms_test.c:

https://gerrit.osmocom.org/#/c/13629/1/tests/db_sms/db_sms_test.c@278
PS1, Line 278: 		struct sms_test *test = sms_test_set + i;
> Use sms_test_set[i]
Ok, will be done in the next patch set.



-- 
To view, visit https://gerrit.osmocom.org/13629
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id94ad35b6f78f839137db2e17010fbf9b40111a3
Gerrit-Change-Number: 13629
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Mon, 15 Apr 2019 15:03:22 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190415/ac7ef0f0/attachment.html>


More information about the gerrit-log mailing list