Change in osmo-msc[master]: large refactoring: support inter-BSC and inter-MSC Handover

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Mon Apr 15 09:00:53 UTC 2019


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13137 )

Change subject: large refactoring: support inter-BSC and inter-MSC Handover
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.osmocom.org/#/c/13137/6/src/libmsc/gsm_04_11.c
File src/libmsc/gsm_04_11.c:

https://gerrit.osmocom.org/#/c/13137/6/src/libmsc/gsm_04_11.c@472
PS6, Line 472: 		return GSM411_RP_CAUSE_MO_NET_OUT_OF_ORDER;
This return looks like memleaking allocated gsms=sms_alloc() in line 467.

Move it before line 467.



-- 
To view, visit https://gerrit.osmocom.org/13137
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I27e4988e0371808b512c757d2b52ada1615067bd
Gerrit-Change-Number: 13137
Gerrit-PatchSet: 6
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 15 Apr 2019 09:00:53 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190415/dc3db92c/attachment.html>


More information about the gerrit-log mailing list