Change in libosmocore[master]: GSUP: add Message Class IE

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Fri Apr 12 14:02:05 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13576 )

Change subject: GSUP: add Message Class IE
......................................................................


Patch Set 4: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/#/c/13576/4/include/osmocom/gsm/gsup.h
File include/osmocom/gsm/gsup.h:

https://gerrit.osmocom.org/#/c/13576/4/include/osmocom/gsm/gsup.h@71
PS4, Line 71: 	= 0x0a,
alignment


https://gerrit.osmocom.org/#/c/13576/3/src/gsm/gsup.c
File src/gsm/gsup.c:

https://gerrit.osmocom.org/#/c/13576/3/src/gsm/gsup.c@739
PS3, Line 739: {}
> I always use {}, and have been doing that all over the place.
But in this particular file all 'value_string' arrays are using '{ 0, NULL }'. Let's please keep the code consistent.



-- 
To view, visit https://gerrit.osmocom.org/13576
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic397a9f2c4a7224e47cab944c72e75ca5592efef
Gerrit-Change-Number: 13576
Gerrit-PatchSet: 4
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Fri, 12 Apr 2019 14:02:05 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190412/47caed41/attachment.html>


More information about the gerrit-log mailing list