Change in osmo-ggsn[master]: ggsn: More logging from PCO handling (e.g. in case of malconfiguration)

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Apr 12 10:23:57 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13609 )

Change subject: ggsn: More logging from PCO handling (e.g. in case of malconfiguration)
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/#/c/13609/3/ggsn/ggsn.c
File ggsn/ggsn.c:

https://gerrit.osmocom.org/#/c/13609/3/ggsn/ggsn.c@570
PS3, Line 570: 	if (!peer_v4) {
> Wondering why IPCP is only used in ipv4...
because IPCP is specified strictly for IPv4 only.  There is no IP6CP (at least not for communicating DNS servers), and as a result, the IPv6 DNS adresses had to be pushed directl into PCO without any IETF format/layer.



-- 
To view, visit https://gerrit.osmocom.org/13609
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38c2c4178ff4fd795f54638adec63166b1c0838e
Gerrit-Change-Number: 13609
Gerrit-PatchSet: 3
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 12 Apr 2019 10:23:57 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190412/17ec3f75/attachment.html>


More information about the gerrit-log mailing list