Change in osmo-gsm-manuals[master]: Makefile.common.inc: add {, un}install targets

osmith gerrit-no-reply at lists.osmocom.org
Fri Apr 12 08:58:26 UTC 2019


osmith has posted comments on this change. ( https://gerrit.osmocom.org/13597 )

Change subject: Makefile.common.inc: add {,un}install targets
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/13597/1/build/Makefile.common.inc
File build/Makefile.common.inc:

https://gerrit.osmocom.org/#/c/13597/1/build/Makefile.common.inc@34
PS1, Line 34: 	if [ "$(OSMO_GSM_MANUALS_NO_INSTALL)" != "1" ]; then \
> According to configure. […]
Good point. But we don't include the Makefile.common.inc unless --enable-manuals is set, so it won't try run the install target from here (or try to build its dependencies, $(PDF_FILES)). I've added a comment to clarify, as you have suggested.

https://git.osmocom.org/osmo-bsc/tree/doc/manuals/Makefile.am

 if BUILD_MANUALS
   ...
   include $(OSMO_GSM_MANUALS_DIR)/build/Makefile.common.inc
 endif


https://gerrit.osmocom.org/#/c/13597/1/build/Makefile.common.inc@36
PS1, Line 36: Dm6
> Probably better using /share/doc/osmo-gsm-manuals/. […]
Done



-- 
To view, visit https://gerrit.osmocom.org/13597
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I66f33172fa410681acbaef4592e9405627948705
Gerrit-Change-Number: 13597
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 12 Apr 2019 08:58:26 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190412/9927ed68/attachment.html>


More information about the gerrit-log mailing list